Add VMware vSphere provider #3419

tkak · 2015-10-06T04:04:23Z

This adds VMware vSphere provider related to #102. This is a direct port from my Terraform plugin for VMware vSphere, terraform-provider-vsphere. Please refer the README for more detail usage.

Example

resource "vsphere_virtual_machine" "default" {
    name = "newvm-1"
    vcpu = 2
    memory = 4096
    disk {
        template = "centos-6.6-x86_64"
    }
    network_interface {
        label = "foo"
    }
}

TODO:

Add documentation
Improve acceptance test code

lesaux · 2015-10-06T14:24:06Z

👍

chrislovecnm · 2015-10-06T16:06:58Z

👍 👏 What is the plan to get this added into a tag / release?

Who wants to open an enhancement request so that we can start brainstorming on next steps? Or I am happy to....

@tkak どうもありがとうございました .... hope google got thank-you very much in japanese correct :)

tkak · 2015-10-07T01:54:16Z

@chrislovecnm Your Japanese comment is correct! Thank you :)

chrislovecnm · 2015-10-07T08:21:37Z

@tkak 先輩 Which versions of vSphere has this been tested against? Trying to lay out a baseline.

@lesaux You using this provider already??

@phinze who needs to approve and merge this?? Just askin cause I need to fork this bad boy 😄

zrml · 2015-10-07T10:22:55Z

This is FANTASTIC! Looking forward ot having this in the core build! Thank you guys. Much obliged @tkak

phinze · 2015-10-07T15:41:43Z

builtin/providers/vsphere/resource_vsphere_virtual_machine.go

+ Optional: true,
+ Elem: &schema.Schema{Type: schema.TypeString},
+ ForceNew: true,
+ },


TypeList is for attributes where the order of the values is significant. If order does not matter, TypeSet is what you want. I'm not familiar with the upstream APIs so this may be correct, but I wanted to let you know so you can double check this for each of your TypeList attributes.

phinze · 2015-10-07T16:33:01Z

Alright, completed initial code review! This is generally looking really solid. 👍

chrislovecnm · 2015-10-07T17:51:01Z

@phinze thanks! Does @tkak now need to make changes? Or do you want to merge the pull and have an issue to apply the changes. Not familiar with your code review process, read through https://github.com/hashicorp/terraform/blob/master/CONTRIBUTING.md ... So would appreciate some guidance 😄

phinze · 2015-10-07T17:59:14Z

@chrislovecnm Generally we give original authors a chance to iterate on their initial PR before we land it. Though if @tkak would like to hand off the improvements to another willing community member that would be OK too. Up to you, @tkak 😀

chrislovecnm · 2015-10-07T21:47:13Z

@tkak 先輩 if you could make the changes that would be awesome!

…n d.Set for complex types

tkak · 2015-10-12T04:41:23Z

@phinze Thanks for your review! I tried to fix some code that were pointed out. And, I want to use TypeList in dns_suffixes and dns_servers, because the configurations are related with DNS search order.

@chrislovecnm My target is VMware vSphere / vCenter 5.5. I mainly use this. Version 6 is not yet introduced in our environment. And govmomi is tested against ESXi and vCenter 5.5.

phinze · 2015-10-12T15:13:36Z

Thanks @tkak! I'm going to merge this as-is and I'll get the provider docs in separately. That will also allow the community to get started on more features / improvements as well. 👍

Add VMware vSphere provider

phinze · 2015-10-12T16:49:30Z

If folks watching this thread are willing to give me a review on #3483 - that gets the structure set up for docs. 👍

mkuzmin · 2015-10-15T03:40:28Z

builtin/providers/vsphere/config.go

+)
+
+const (
+ defaultInsecureFlag = true


This is a security hole.
SSL certificate validation must be switched on by default, and has to be disabled by a user explicitly.

mkuzmin · 2015-10-15T05:56:48Z

My target is VMware vSphere / vCenter 5.5. I mainly use this. Version 6 is not yet introduced in our environment.

Such answer was OK while you maintained a standalone 3rd-party plugin. Now when the code has been merged into the product, things are different. HashiCorp people have no experience in VMware technologies and tools, so you are the maintainer, and you are responsible of having this feature working well.
Terraform users do not care of details of your employer's environment.

phinze · 2015-10-15T21:21:05Z

@mkuzmin Thanks for the review!

Your inline comments make sense - going to fan those out into individual issues so we can address them.

This is just a first step - @tkak got us started, and now the community can collaborate to improve and extend from here.

Since there has been so much community demand for vSphere support in core, we felt that it was better to get a pre-release version merged so we can have more people help out with its development. To help make sure users are aware of this status, I added notes about "initial support" in both the changelog and the docs.

Paul, how do you usually run acceptance tests for AWS and other providers. I don't see them in your Travis build.

Alas, this is still a manual process. I'm investigating the possibility of gaining access to a vSphere environment for us to run acceptance tests on.

I'll link the new issues I create back to this thread for continuity. 👍

mkuzmin · 2015-10-15T21:50:58Z

Do you think it's better to move all further conversations into new issues, and stop this thread?
That's fine for bug reports and pull requests, but what is a correct place to discuss internal code changes like parameter renaming, or this test execution task?
My company could sponsor that, but we need to figure out details.

phinze · 2015-10-15T22:00:25Z

Yep I was thinking we can close this thread and address each of those concerns as individual issue threads, since they're not tightly related. I'll get these made now so you can see what I mean.

tkak · 2015-10-18T05:55:51Z

@mkuzmin Thank you for the review and the advice.

Such answer was OK while you maintained a standalone 3rd-party plugin. Now when the code has been merged into the product, things are different. HashiCorp people have no experience in VMware technologies and tools, so you are the maintainer, and you are responsible of having this feature working well.

I think you are right. I will try to prepare a test environment in my company to support VMware vSphere 6.

mevansam · 2015-10-23T02:25:53Z

This is awesome. I am sorry I have not been following the vSphere provider thread for a while, but I am back. I will work on providing a patch to the merged vSphere provider for the pieces I was working on.

mrjcleaver · 2016-09-26T10:49:06Z

I note the TODO documentation and comment "I'll get the provider docs in separately. "

Has documentation been updated? I ask because there are details in the original project (such as network adapter notes) that I didn't see on the terraform docs provider section on the website.

ghost · 2020-04-22T01:53:39Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

tkak mentioned this pull request Oct 6, 2015

Begin upstream merge process to Terraform core? rakutentech/terraform-provider-vsphere#42

Open

Add VMware vSphere provider support

231d787

tkak force-pushed the add-vsphere-provider branch from eb7f82c to 231d787 Compare October 6, 2015 04:25

radeksimko added the enhancement label Oct 6, 2015

phinze reviewed Oct 7, 2015
View reviewed changes

Refactor ResourceData, pluralize some arguments and add error check i…

f34628d

…n d.Set for complex types

phinze added a commit that referenced this pull request Oct 12, 2015

Merge pull request #3419 from rakutentech/add-vsphere-provider

f773732

Add VMware vSphere provider

phinze merged commit f773732 into hashicorp:master Oct 12, 2015

apparentlymart mentioned this pull request Oct 14, 2015

Add support for vmware #102

Closed

mkuzmin reviewed Oct 15, 2015
View reviewed changes

This was referenced Oct 15, 2015

vsphere: turn on SSL verification and expose configuration option to disable #3521

Closed

vsphere: rename "vcenter_server" config parameter to something clearer #3522

Closed

vsphere: document how to run acceptance tests #3524

Closed

bryanrossUK mentioned this pull request Oct 26, 2015

Add support for VMware vRealize Automation #3642

Closed

nickithewatt mentioned this pull request Nov 6, 2015

Add VMware vCloud Director (vcd) provider #3784

Closed

ghost locked and limited conversation to collaborators Apr 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add VMware vSphere provider #3419

Add VMware vSphere provider #3419

tkak commented Oct 6, 2015

lesaux commented Oct 6, 2015

chrislovecnm commented Oct 6, 2015

tkak commented Oct 7, 2015

chrislovecnm commented Oct 7, 2015

zrml commented Oct 7, 2015

phinze Oct 7, 2015

phinze commented Oct 7, 2015

chrislovecnm commented Oct 7, 2015

phinze commented Oct 7, 2015

chrislovecnm commented Oct 7, 2015

tkak commented Oct 12, 2015

phinze commented Oct 12, 2015

phinze commented Oct 12, 2015

mkuzmin Oct 15, 2015

mkuzmin commented Oct 15, 2015

phinze commented Oct 15, 2015

mkuzmin commented Oct 15, 2015

phinze commented Oct 15, 2015

tkak commented Oct 18, 2015

mevansam commented Oct 23, 2015

mrjcleaver commented Sep 26, 2016

ghost commented Apr 22, 2020

Add VMware vSphere provider #3419

Add VMware vSphere provider #3419

Conversation

tkak commented Oct 6, 2015

Example

lesaux commented Oct 6, 2015

chrislovecnm commented Oct 6, 2015

tkak commented Oct 7, 2015

chrislovecnm commented Oct 7, 2015

zrml commented Oct 7, 2015

phinze Oct 7, 2015

Choose a reason for hiding this comment

phinze commented Oct 7, 2015

chrislovecnm commented Oct 7, 2015

phinze commented Oct 7, 2015

chrislovecnm commented Oct 7, 2015

tkak commented Oct 12, 2015

phinze commented Oct 12, 2015

phinze commented Oct 12, 2015

mkuzmin Oct 15, 2015

Choose a reason for hiding this comment

mkuzmin commented Oct 15, 2015

phinze commented Oct 15, 2015

mkuzmin commented Oct 15, 2015

phinze commented Oct 15, 2015

tkak commented Oct 18, 2015

mevansam commented Oct 23, 2015

mrjcleaver commented Sep 26, 2016

ghost commented Apr 22, 2020